[file_selector] Migrate FileSelectorApi to Dart #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugerossetto
reviewed
Oct 6, 2022
packages/file_selector/file_selector_windows/test/file_selector_api_test.dart
Outdated
Show resolved
Hide resolved
add test suite for file_selector_api
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
9b075ef to
ec3fda6
Compare
|
Closing this because it is opened in the main repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes in #6518 and in #6539.
This exposes a new FileSelectorApi that will replace the one generated by pigeon.
This will be integrated with the next PR.
Things we have done:
Issue: [file_selector_windows] Migrate CPP implementation to Dart. #112212
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.