Skip to content

Let goto definition work from UnresolvedOverloading error calls#943

Merged
soutaro merged 1 commit intomasterfrom
goto-from-error
Oct 27, 2023
Merged

Let goto definition work from UnresolvedOverloading error calls#943
soutaro merged 1 commit intomasterfrom
goto-from-error

Conversation

@soutaro
Copy link
Owner

@soutaro soutaro commented Oct 27, 2023

This fixes a bug that goto definition from method calls with errors don't work sometimes.

スクリーンショット 2023-10-27 10 10 05

This is caused because MethodCall::Error instantiation doesn't have method_decls if UnresolvedOverloading is to be reported.

@soutaro soutaro added area/core Issues related to the type checker core area/lsp Issues related to language server labels Oct 27, 2023
@soutaro soutaro added this to the Steep 1.6 milestone Oct 27, 2023
@soutaro soutaro merged commit ebb276f into master Oct 27, 2023
@soutaro soutaro deleted the goto-from-error branch October 27, 2023 01:57
@soutaro soutaro added the Released The PR is already included in a published release label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to the type checker core area/lsp Issues related to language server Released The PR is already included in a published release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant