Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/steep/type_inference/send_args.rb
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,15 @@ def each
when KeywordArgs::MissingKeyword
missing_keywords.push(*error.keywords.to_a)
when PositionalArgs::UnexpectedArg
diagnostics << Diagnostic::Ruby::UnexpectedPositionalArgument.new(node: error.node, params: params)
if error.node.type == :kwargs
error.node.children.each do |kwarg|
if kwarg.type == :pair
diagnostics << Diagnostic::Ruby::UnexpectedKeywordArgument.new(node: kwarg, params: params)
end
end
else
diagnostics << Diagnostic::Ruby::UnexpectedPositionalArgument.new(node: error.node, params: params)
end
when PositionalArgs::MissingArg
diagnostics << Diagnostic::Ruby::InsufficientPositionalArguments.new(node: node, params: params)
end
Expand Down
32 changes: 32 additions & 0 deletions test/type_check_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1358,4 +1358,36 @@ def foo(context)
YAML
)
end

def test_argument_error__unexpected_unexpected_positional_argument
run_type_check_test(
signatures: {
"a.rbs" => <<~RBS
class Foo
def foo: () -> void
end
RBS
},
code: {
"a.rb" => <<~RUBY
Foo.new.foo(hello_world: true)
RUBY
},
expectations: <<~YAML
---
- file: a.rb
diagnostics:
- range:
start:
line: 1
character: 12
end:
line: 1
character: 23
severity: ERROR
message: Unexpected keyword argument
code: Ruby::UnexpectedKeywordArgument
YAML
)
end
end