Skip to content

Reuse the latest result to keep SignatureHelp opened while typing#835

Merged
soutaro merged 1 commit intosoutaro:masterfrom
tk0miya:reuse_latest_SignatureHelp_on_SyntaxError
Jul 5, 2023
Merged

Reuse the latest result to keep SignatureHelp opened while typing#835
soutaro merged 1 commit intosoutaro:masterfrom
tk0miya:reuse_latest_SignatureHelp_on_SyntaxError

Conversation

@tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Jul 5, 2023

refs: #834

Is sending the latest signature help response better if SyntaxError is raised?

It seems this approach working fine to me :-)

preview

Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the Steep 1.5 milestone Jul 5, 2023
@soutaro soutaro merged commit ee0a525 into soutaro:master Jul 5, 2023
@soutaro soutaro added the Released The PR is already included in a published release label Jul 5, 2023
@tk0miya tk0miya deleted the reuse_latest_SignatureHelp_on_SyntaxError branch July 27, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released The PR is already included in a published release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants