Skip to content

Skip pending UI jobs#1035

Merged
soutaro merged 3 commits intomasterfrom
interaction
Jan 29, 2024
Merged

Skip pending UI jobs#1035
soutaro merged 3 commits intomasterfrom
interaction

Conversation

@soutaro
Copy link
Owner

@soutaro soutaro commented Jan 29, 2024

It looks like completion requests are sent multiple times from VSCode and it waits for seconds to finish all of them, while only the last completion request makes sense.

This PR skips prior UI jobs before processing the last queued one.

  • Pros: UI responsiveness improvements
  • Cons: UI requests loss -- dropping completion request always makes sense, but how about SignatureHelp?

@soutaro soutaro added this to the Steep 1.7 milestone Jan 29, 2024
@soutaro soutaro enabled auto-merge January 29, 2024 12:44
@soutaro soutaro merged commit 171de86 into master Jan 29, 2024
@soutaro soutaro deleted the interaction branch January 29, 2024 12:48
@soutaro soutaro added Released The PR is already included in a published release and removed Released The PR is already included in a published release labels Jan 30, 2024
@ParadoxV5
Copy link
Contributor

It looks like completion requests are sent multiple times from VSCode and it waits for seconds to finish all of them, while only the last completion request makes sense.

Is this a mistake on VSCode’s side? If it’s intended, why?

@soutaro
Copy link
Owner Author

soutaro commented Feb 25, 2024

I think it's intended. Typing in the editor requires new completion items because the text is changed. The root cause of the unresponsive UI is the slow type checking performance of Steep.

@soutaro soutaro added the Released The PR is already included in a published release label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released The PR is already included in a published release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants