`UnnecessaryImport` removes star import from same package

[jhonnen]

Given the following class

package some.pkg;

import static some.pkg.ImportedClass.*;

class SomeClass {
}

The UnnecessaryImport mutator removes the star import. The cause is a subtle bug in

cleanthat/java/src/main/java/eu/solven/cleanthat/engine/java/refactorer/mutators/UnnecessaryImport.java

Lines 207 to 211 in fa9f073

	var imp = i.getNameAsString();
	if (packageName.isEmpty()) {
	return !imp.contains(".");
	}
	return imp.startsWith(packageName) && imp.lastIndexOf('.') <= packageName.length();

getNameAsString() for that ImportDeclaration returns some.pkg.ImportedClass and not some.pkg.ImportedClass.* as one could expect. Therefore the import is removed.

[blacelle]

Thanks for the comprehensive report @jhonnen . The fix is ready, I'll release CleanThat 2.16 within hours

[jhonnen]

That was fast, thank you!

[blacelle]

2.16 is released. It may (or may not) take some hours to become available through m2central.