Modernize TSConfig #157
Open
Modernize TSConfig #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your TSConfig hasn't been updated for over 2 years. I didn't have any particular issue with it, but I think it benefits from an update.
The TSConfig I used is based on this guide and Vite's default TSConfig for React.
I ran
pnpm buildandpnpm tsc --noEmitto ensure all templates build correctly and found (and fixed) all sorts of wired bugs and inconsistencies. For example, missing packages, missing.gitignorefile or TypeScript errors. I didn't feel like creating a separate PR for it, but if you are strict with this sort of stuff I can divide it into two PRs.