Skip to content

fix: issue #795 #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: issue #795 #797

wants to merge 6 commits into from

Conversation

007qr
Copy link

@007qr 007qr commented Jun 4, 2025

This PR fixes the issue: #795

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8a7d125

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

thetarnav
thetarnav reviewed Jun 13, 2025
View reviewed changes
atk
atk requested changes Jun 26, 2025
View reviewed changes
Copy link
Member

@atk atk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's discuss the API. I dislike the boolean and that the params need to be wrapped in a function even if they are not supposed to change.

packages/pagination/src/index.ts
@@ -246,71 +246,166 @@ declare module "solid-js" {
export type _E = JSX.Element;

/**
* Provides an easy way to implement infinite scrolling.
* A SolidJS utility to create an infinite scrolling experience with IntersectionObserver and reactivity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to explicitly mention SolidJS here when the whole package is part of solid-primitives.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure will improve this

packages/pagination/src/index.ts
* A function that takes a page number and optional parameters and returns a Promise resolving to an array of items.
*
* @param {Object} [options] - Optional configuration object.
* @param {() => P} [options.params] - A reactive accessor for dynamic fetcher parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use the pattern that we take a params object or a params object signal. If it is a signal, we expect that we should reset state on params change; otherwise, we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetarnav thetarnav thetarnav left review comments

@atk atk atk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@007qr @atk @thetarnav