Upgrade to Rust 1.43.0 #9754

mvines · 2020-04-28T04:39:39Z

No description provided.

solana-grimes · 2020-04-28T06:27:03Z

💔 Unable to automerge due to CI failure

solana-grimes · 2020-04-28T08:04:35Z

💔 Unable to automerge due to CI failure

solana-grimes · 2020-04-28T16:39:30Z

💔 Unable to automerge due to CI failure

mvines · 2020-04-28T16:59:49Z

@jackcmay - could you please take a look at this build error with 1.43.0, it's in the xargo goo that you're the most familiar with:

error: the `-Z unstable-options` flag must also be passed to enable `--extern crate_name` without `=path`

STR:

cargo +1.43.0 test --manifest-path programs/bpf/Cargo.toml --no-default-features --features=bpf_c,bpf_rust --verbose -- --nocapture

jackcmay · 2020-04-28T17:14:55Z

@mvines I can recreate locally, I'll dig into it

jackcmay · 2020-04-28T23:56:35Z

@mvines, I have a fix, just need this to land first:
#9781

mvines · 2020-04-29T00:37:21Z

Sweet

mvines · 2020-04-29T04:14:20Z

@Mergifyio rebase

mergify · 2020-04-29T04:14:58Z

Command rebase: success

jackcmay · 2020-04-29T04:31:38Z

The following PR fixes the CI issue seen in this PR
#9783

mvines · 2020-04-29T06:51:36Z

@Mergifyio rebase

mergify · 2020-04-29T06:52:47Z

Command rebase: success

mergify · 2020-04-29T07:20:43Z

Command rebase: success

mergify · 2020-04-29T07:20:50Z

Command rebase: success

mergify · 2020-04-29T07:56:41Z

Command rebase: success

mergify · 2020-04-29T07:57:58Z

Command rebase: success

mergify · 2020-04-29T08:01:28Z

Command rebase: success

mergify · 2020-04-29T08:06:32Z

Command rebase: success

mergify · 2020-04-29T08:07:15Z

Command rebase: success

mergify · 2020-04-29T08:08:03Z

Command rebase: success

mergify · 2020-04-29T08:13:18Z

Command rebase: success

mergify · 2020-04-29T08:24:13Z

Command rebase: success

mergify · 2020-04-29T08:27:45Z

Command rebase: success

mergify · 2020-04-29T08:28:35Z

Command rebase: success

mergify · 2020-04-29T09:25:05Z

Command rebase: success

mergify · 2020-04-29T09:25:16Z

Command rebase: success

mergify · 2020-04-29T09:25:18Z

Command rebase: success

mergify · 2020-04-29T09:25:20Z

Command rebase: failure

mergify · 2020-04-29T09:25:48Z

Command rebase: success

mergify · 2020-04-29T09:27:59Z

Command rebase: success

codecov · 2020-04-29T09:39:10Z

Codecov Report

@@           Coverage Diff            @@
##           master   #9754     +/-   ##
========================================
- Coverage    80.4%   80.4%   -0.1%     
========================================
  Files         281     281             
  Lines       64643   64524    -119     
========================================
- Hits        51979   51879    -100     
+ Misses      12664   12645     -19

mergify · 2020-04-29T09:46:04Z

Command rebase: success

mergify · 2020-04-29T11:57:53Z

Command rebase: success

jackcmay · 2020-04-29T18:47:04Z

@mvines v1.0 and v1.1 will probably also need the rust-bpf bump and possibly related cache fix

mvines · 2020-04-29T18:53:21Z

yeah I was thinking that. Can you backport those too?

mvines · 2020-04-30T01:01:57Z

Ok here we go!

(cherry picked from commit 230df0e) # Conflicts: # core/src/validator.rs # runtime/src/accounts_db.rs

(cherry picked from commit 230df0e)

automerge

* Upgrade to Rust 1.43.0 (#9754) (cherry picked from commit 230df0e) # Conflicts: # core/src/validator.rs # runtime/src/accounts_db.rs * Update validator.rs * Update accounts_db.rs Co-authored-by: Michael Vines <[email protected]>

mvines added v1.0 labels Apr 28, 2020

mvines force-pushed the r43 branch from 8a8b8ae to 64cb582 Compare April 28, 2020 05:38

mvines added the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

mvines force-pushed the r43 branch from 64cb582 to 151cfbf Compare April 28, 2020 06:40

mvines added the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

mvines force-pushed the r43 branch from 151cfbf to 8e466db Compare April 28, 2020 15:24

mvines added the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Apr 28, 2020

jstarry force-pushed the r43 branch from 8e466db to 146fe71 Compare April 29, 2020 04:14

jackcmay mentioned this pull request Apr 29, 2020

Bump Rust-BPF version to be interoperable with latest Cargo #9783

Merged

mvines added 2 commits April 29, 2020 06:52

Upgrade to Rust 1.43.0

18bf750

Update stable and nightly in test-bench.sh

0b0d5a5

jstarry force-pushed the r43 branch from 146fe71 to 0b0d5a5 Compare April 29, 2020 06:52

mvines merged commit 230df0e into solana-labs:master Apr 30, 2020

mergify bot pushed a commit that referenced this pull request Apr 30, 2020

Upgrade to Rust 1.43.0 (#9754)

d9cee68

(cherry picked from commit 230df0e) # Conflicts: # core/src/validator.rs # runtime/src/accounts_db.rs

mergify bot mentioned this pull request Apr 30, 2020

Upgrade to Rust 1.43.0 (bp #9754) #9807

Merged

mergify bot pushed a commit that referenced this pull request Apr 30, 2020

Upgrade to Rust 1.43.0 (#9754)

9407b6f

(cherry picked from commit 230df0e)

mergify bot mentioned this pull request Apr 30, 2020

Upgrade to Rust 1.43.0 (bp #9754) #9808

Merged

solana-grimes pushed a commit that referenced this pull request Apr 30, 2020

Upgrade to Rust 1.43.0 (#9754) (#9808)

a8eb935

automerge

ryoqun mentioned this pull request Jun 15, 2020

Update to rust 1.44.0 #10585

Merged

Upgrade to Rust 1.43.0 #9754

Upgrade to Rust 1.43.0 #9754

Uh oh!

Conversation

mvines commented Apr 28, 2020

Uh oh!

solana-grimes commented Apr 28, 2020

Uh oh!

solana-grimes commented Apr 28, 2020

Uh oh!

solana-grimes commented Apr 28, 2020

Uh oh!

mvines commented Apr 28, 2020

Uh oh!

jackcmay commented Apr 28, 2020

Uh oh!

jackcmay commented Apr 28, 2020

Uh oh!

mvines commented Apr 29, 2020

Uh oh!

mvines commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

jackcmay commented Apr 29, 2020

Uh oh!

mvines commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

codecov bot commented Apr 29, 2020

Codecov Report

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

mergify bot commented Apr 29, 2020

Uh oh!

jackcmay commented Apr 29, 2020

Uh oh!

mvines commented Apr 29, 2020

Uh oh!

mvines commented Apr 30, 2020

Uh oh!

Uh oh!