Issue 268 - Support for tool calls #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Mar 24, 2025
README.md
Outdated
| @@ -539,6 +539,136 @@ val jsonSchema: ASchema = TapirSchemaToJsonSchema( | |||
| ) | |||
| ``` | |||
|
|
|||
| #### Generating JSON Schema from case class | |||
|
|
|||
| We can also generate JSON Schema directly from case class, without defining the schema manually: | |||
There was a problem hiding this comment.
I would expand this a bit:
- some more detail on how this differs from the example immediately above
- first mention the methods that the section focuses on (as I understand, this is about
SchematizedFunctionTool?), describe how this works, and only later proceed to the example. The example is long and it might be hard understanding what's the main point
adamw
reviewed
Mar 24, 2025
|
|
||
| val initialRequestMessage = Seq(UserMessage(content = TextContent("I want to book a flight from London to Tokyo for Jane Doe, age 34"))) | ||
|
|
||
| val givenRequest = ChatBody( |
There was a problem hiding this comment.
let's add some comments here describing how this differs from a "normal" open ai request, and what amount of labor we are saving
adamw
reviewed
Mar 24, 2025
| ) | ||
| */ | ||
|
|
||
| val toolCalls = initialRequestResult.choices.head.message.toolCalls |
There was a problem hiding this comment.
here again, some context on what you're trying to achieve with that code would be good. Also earlier: what functionality are you implementing in the example? What are the actors? There's a user which specifies the prompt, there's ChatGPT, and there's a booking service - it would be good to introduce them first
adamw
reviewed
Mar 24, 2025
| @@ -16,6 +20,31 @@ object Tool { | |||
| */ | |||
| case class FunctionTool(description: String, name: String, parameters: Map[String, Value]) extends Tool | |||
|
|
|||
| case class SchematizedFunctionTool(description: String, name: String, parameters: Schema) extends Tool | |||
There was a problem hiding this comment.
some scalados here would be nice, specifying when to use FuntionTool, and when this class, and in which API
adamw
reviewed
Mar 25, 2025
adamw
approved these changes
Mar 25, 2025
Co-authored-by: Adam Warski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.