Skip to content

Handle nullable finish_reason in the streamed chunk completion choice #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Handle nullable finish_reason in the streamed chunk completion choice #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/sttp/openai/requests/completions/chat/ChatChunkRequestResponseData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ object ChatChunkRequestResponseData {

case class Choices(
delta: Delta,
finishReason: Option[String],
finishReason: Option[String] = None,
index: Int
)

Expand Down
8 changes: 7 additions & 1 deletion core/src/test/scala/sttp/openai/fixtures/ChatChunkFixture.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,12 @@ object ChatChunkFixture {
| "system_fingerprint": "systemFingerprint",
| "choices": [
| {
| "delta": {
| "content": "..."
| },
| "index": 0
| },
| {
| "delta": {
| "role": "assistant",
| "content": " Hi",
Expand All @@ -140,7 +146,7 @@ object ChatChunkFixture {
| ]
| },
| "finish_reason": "stop",
| "index": 0
| "index": 1
| }
| ]
|}""".stripMargin
Expand Down
29 changes: 18 additions & 11 deletions core/src/test/scala/sttp/openai/requests/completions/chat/ChatChunkDataSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,31 @@ class ChatChunkDataSpec extends AnyFlatSpec with Matchers with EitherValues {
// given
val jsonResponse = fixtures.ChatChunkFixture.jsonResponse

val delta: Delta = Delta(
role = Some(Role.Assistant),
content = Some(" Hi"),
toolCalls = toolCalls
)

val choices: Choices = Choices(
delta = delta,
finishReason = Some("stop"),
index = 0
val choices = Seq(
Choices(
delta = Delta(
content = Some("...")
),
finishReason = None,
index = 0
),
Choices(
delta = Delta(
role = Some(Role.Assistant),
content = Some(" Hi"),
toolCalls = toolCalls
),
finishReason = Some("stop"),
index = 1
)
)

val expectedResponse: ChatChunkResponse = ChatChunkResponse(
id = "chatcmpl-76FxnKOjnPkDVYTAQ1wK8iUNFJPvR",
`object` = "chat.completion",
created = 1681725687,
model = "gpt-3.5-turbo-0301",
choices = Seq(choices),
choices = choices,
systemFingerprint = Some("systemFingerprint")
)

Expand Down