extend Audio & Models API's #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygiert1990
commented
Mar 7, 2025
Comment on lines
19
to
31
| /** Generates audio from the input text. | ||
| * | ||
| * [[https://platform.openai.com/docs/api-reference/audio/createSpeech]] | ||
| * | ||
| * @param requestBody | ||
| * Request body that will be used to create a speech. | ||
| * | ||
| * @return | ||
| * The audio file content. | ||
| */ | ||
| def createSpeech(requestBody: SpeechRequestBody): Request[Either[OpenAIException, InputStream]] = | ||
| client.createSpeechAsInputStream(requestBody) | ||
|
|
There was a problem hiding this comment.
Not sure does it make any sense to put here this method, as this is just delegation to client method, which doesn't do any further action.
There was a problem hiding this comment.
I think it doesn't as this extension is about streaming, and there's no streaming here
There was a problem hiding this comment.
(well, no ox-streaming, just regular Java InputStream)
zygiert1990
changed the title
zygiert1990
changed the title
added 9 commits
March 10, 2025 10:10
zygiert1990
force-pushed
the
extend_audio_models_threads_apis
branch
from
e516d8f to
82d87e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.