Skip to content

Fix build on RN 0.74 #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix build on RN 0.74 #3024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a27f93f
Fixes
m-bert Jul 31, 2024
6e22741
Update android/src/main/jni/cpp-adapter.cpp
m-bert Aug 1, 2024
8d5644b
Update apple/RNGestureHandlerModule.mm
m-bert Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions android/src/main/jni/cpp-adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@ void decorateRuntime(jsi::Runtime &runtime) {
return jsi::Value::null();
}

auto shadowNodeWrapper = arguments[0]
.asObject(runtime).getNativeState<ShadowNodeWrapper>(runtime);
bool isFormsStackingContext = shadowNodeWrapper->shadowNode->getTraits()
.check(ShadowNodeTraits::FormsStackingContext);
auto shadowNode = shadowNodeFromValue(runtime, arguments[0]);
bool isFormsStackingContext = shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);

return jsi::Value(isFormsStackingContext);
});
Expand Down
6 changes: 2 additions & 4 deletions apple/RNGestureHandlerModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@ void decorateRuntime(jsi::Runtime &runtime)
if (!arguments[0].isObject()) {
return jsi::Value::null();
}

auto shadowNodeWrapper = arguments[0].asObject(runtime).getNativeState<ShadowNodeWrapper>(runtime);
bool isFormsStackingContext =
shadowNodeWrapper->shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);
auto shadowNode = shadowNodeFromValue(runtime, arguments[0]);
bool isFormsStackingContext = shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);
return jsi::Value(isFormsStackingContext);
});
runtime.global().setProperty(runtime, "isFormsStackingContext", std::move(isFormsStackingContext));
Expand Down
Loading