build: fix problems with crashes on iPads #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmjkb
reviewed
Jul 2, 2025
| "-force_load \"#{et_binaries_path}\"/libbackend_coreml_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libbackend_mps_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libbackend_xnnpack_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libexecutorch_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libkernels_custom_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libkernels_optimized_simulator.a", | ||
| "-force_load \"#{et_binaries_path}\"/libkernels_quantized_simulator.a", | ||
| "\"#{et_binaries_path}\"/libkernels_portable_simulator.a", |
There was a problem hiding this comment.
I believe you can use vendored_libraries instead of OTHER_LDFLAGS, a bit cleaner though. The latter was used mostly due to the need of passing the --force-load flag. Same goes for tokenizers. You can try to make it work :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates static libraries(.a) files for iOS, so they support iOS in version 16 and newer, it also solves the problem with crashes on iPads. Also missing libkernels_portable was added. I suggest to wait with this PR until all features are rewritten to CPP and then also remove
s.ios.vendored_frameworksline from podspec as it won't be needed anymore, and currently it overwrites linked static librariesType of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes