fix: division operator resolution #1446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
iwoplaza
requested changes
Jul 3, 2025
aleksanderkatan
requested changes
Jul 14, 2025
|
|
||
| if (!lhsIsFloat && !rhsIsFloat) { | ||
| console.warn( | ||
| 'In division we cast both sides to the f32. This may not be the expected behaviour. Consider using explicit conversions instead.', |
There was a problem hiding this comment.
Do we use GB English (behaviour)?
There was a problem hiding this comment.
We might have to decide upon that in the future. This does not matter here, as those warnings are deemed unnecessary (we aim to mimic JS) and will be removed.
aleksanderkatan
approved these changes
Jul 14, 2025
reczkok
requested changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.