Skip to content

Conversation

PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Jun 13, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR updates golang from 1.23 to 1.24 and adapt to the new FIPS related aspects.

  1. Updated how FIPS is enabled chore: upgrade to go 1.24 go-application-framework#391
  2. Update golang version build image
  3. Updated e2e test image to use an image that has fips enabled by default

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

Copy link

snyk-io bot commented Jun 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Jul 14, 2025
@github-actions github-actions bot removed the Stale label Jul 15, 2025
@PeterSchafer PeterSchafer force-pushed the chore/go-1.24_e2e branch 9 times, most recently from 1363dd7 to e0cbd35 Compare July 31, 2025 10:14
@PeterSchafer PeterSchafer marked this pull request as ready for review July 31, 2025 10:15
@PeterSchafer PeterSchafer requested a review from a team as a code owner July 31, 2025 10:15
@@ -1,5 +1,6 @@
.bin/
.circleci/
!.circleci/awscli-publickey.pub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required during building the build image.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Aug 1, 2025

Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 0f6394b

@PeterSchafer PeterSchafer merged commit 235099f into main Aug 1, 2025
9 checks passed
@PeterSchafer PeterSchafer deleted the chore/go-1.24_e2e branch August 1, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants