Quick-and-dirty fix for CVE-2023-43669 #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalakhov
force-pushed
the
CVE-2023-43669
branch
from
2bc3d85 to
f204f1b
Compare
daniel-abramov
approved these changes
Sep 22, 2023
Member
daniel-abramov
left a comment
daniel-abramov
left a comment
There was a problem hiding this comment.
Thanks for tackling this issue! I've left a couple of minor comments, but overall it looks good for a quick fix!
Co-authored-by: Daniel Abramov <[email protected]>
agalakhov
force-pushed
the
CVE-2023-43669
branch
from
c574f50 to
f0f1a06
Compare
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds header limits in order to reject suspicious requests.
It were much better to use single-pass header parsing instead. Unfortunately,
httparsedoes not support it yet and none of its alternatives is mature enough.