Tighten substitution pattern for Fn::Sub#842
Merged
gosar merged 1 commit intosmithy-lang:mainfrom Jun 25, 2021
Merged
Conversation
CloudFormation variables can be parameter names, resource logical IDs or resource attributes. * Parameter names: can be alphanumeric or pseudo-parameters, which can be prefixed with "AWS::" * Resource logical IDs: can be alphanumeric. * Resource attributes: specified as resourceLogicalId.attributeName, where attributeName is also alphanumeric.
.../src/main/java/software/amazon/smithy/aws/apigateway/openapi/CloudFormationSubstitution.java
Show resolved
Hide resolved
JordonPhillips
approved these changes
Jun 25, 2021
gosar
added a commit
to gosar/smithy
that referenced
this pull request
Jul 9, 2021
This reverts commit fd5731f.
JordonPhillips
pushed a commit
that referenced
this pull request
Jul 12, 2021
This reverts commit fd5731f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
CloudFormation variables can be parameter names, resource logical IDs
or resource attributes.
From https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html - Variables can be template parameter names, resource logical IDs, resource attributes, or a variable in a key-value map. If you specify only template parameter names, resource logical IDs, and resource attributes, don't specify a key-value map. . This code is not meant for using the 2nd key-value map parameter in Fn::Sub. So, for the others:
** Pseudo parameters: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html - alphanumeric prefixed with
AWS::The code change is going from looser to restrictive, but given the above, anything else this code allowed earlier, would have not worked end-to-end.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.