Skip to content

Add tests for writing in sections. #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtdowling merged 2 commits into from
Nov 3, 2020
Merged

Add tests for writing in sections. #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b004d
Add tests for writing in sections. The inline test is failing due to…
kggilmer Oct 29, 2020
7512f16
Fix writeInline onSection bug
mtdowling Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions smithy-utils/src/main/java/software/amazon/smithy/utils/CodeWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,10 +667,10 @@ private String getTrimmedPoppedStateContents(State state) {

// Remove the trailing newline, if present, since it gets added in the
// final call to writeOptional.
if (builder != null
&& builder.length() > 0
&& builder.charAt(builder.length() - 1) == currentState.newline) {
builder.delete(builder.length() - 1, builder.length());
if (builder != null && builder.length() > 0) {
if (builder.charAt(builder.length() - 1) == currentState.newline) {
builder.delete(builder.length() - 1, builder.length());
}
result = builder.toString();
}

Expand Down
29 changes: 29 additions & 0 deletions smithy-utils/src/test/java/software/amazon/smithy/utils/CodeWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,4 +696,33 @@ public void canComposeSetWithSection() {

assertThat(writer.toString(), equalTo("[1, 2, 3]\n"));
}

public void sectionWithWrite() {
String testSection = "TEST_SECTION";
CodeWriter writer = new CodeWriter();

writer.onSection(testSection, text -> {
writer.write(text + "addition");
});

writer.pushState(testSection);
writer.popState();

assertThat(writer.toString(), equalTo("addition\n"));
}

@Test
public void sectionWithWriteInline() {
String testSection = "TEST_SECTION";
CodeWriter writer = new CodeWriter();

writer.onSection(testSection, text -> {
writer.writeInline(text + "inline addition");
});

writer.pushState(testSection);
writer.popState();

assertThat(writer.toString(), equalTo("inline addition\n"));
}
}