Merged
Conversation
Smithy-diff previously did not emit validation events when a trait was added, removed, or changed unless the trait was marked with one of a few special tags. This commit updates smithy-diff to emit a NOTE when a trait is added or changed and a WARNING when a trait is removed. This helps ensure that all trait changes are caught by smithy-diff, while still allowing more granular control through the tags.
kstich
reviewed
Sep 11, 2020
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/ModifiedTrait.java
Outdated
Show resolved
Hide resolved
smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/ModifiedTraitTest.java
Outdated
Show resolved
Hide resolved
…rs/ModifiedTrait.java Co-authored-by: Kevin Stich <stickevi@amazon.com>
…rs/ModifiedTraitTest.java Co-authored-by: Kevin Stich <stickevi@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smithy-diff previously did not emit validation events when a trait was
added, removed, or changed unless the trait was marked with one of a few
special tags. This commit updates smithy-diff to emit a NOTE when a
trait is added or changed and a WARNING when a trait is removed. This
helps ensure that all trait changes are caught by smithy-diff, while
still allowing more granular control through the tags.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.