Conversation
* Adds an aws.api#service trait, sdkId="EC2 Protocol" * Uses correct Idempotency token property names * Uses correct Idempotency token test Action names * Fixes auto-generated idempotency token value * Fixes list member name capitalization * Adds missing "/" to a closing XML element
* Fix issue with b64 encoding blobs
* Fixes service name in several x-amz-target headers
* Fixes an operation name in x-amz-target header
* Removes errant required header when not supplied
* Fixes several [] vs {} discrepancies for empty structures
* Adds missing body for operation that has a response
* Adds an aws.api#service trait, sdkId="Query Protocol" * Fixes several test Action names * Fixes auto-generated idempotency token value * Fixes several map/list entry and value counter issues * Fixes discrepancies with map list member serialized keys * Adds missing "/" to a closing XML element * Fixes several xmlName trait discrepancies * Fixes several result wrapper shape names
* Adds an aws.api#service trait, sdkId="Rest Json Protocol" * Fixes several uri discrepancies * Fixes missing x-amzn-errortype header * Fixes several header name and value discrepancies * Fixes several issues where a member indicating a dateTime was using a shape of the incorrect format * Fixes auto-generated idempotency token value * Fix requiring a param when no content can set it * Fixes several jsonName trait discrepancies * Removes header serialized values from bodies * Fixes issues with label encoding * Updates NullAndEmptyHeaders tests
* Adds an aws.api#service trait, sdkId="Rest Xml Protocol" * Fixes several uri discrepancies * Adds missing "/" to a closing XML element * Fixes several xmlName trait discrepancies * Fixes several request root element names * Fixes several header name and value discrepancies * Fixes several issues where a member indicating a dateTime was using a shape of the incorrect format * Adds missing ":" to serialized namespace uris * Fixes auto-generated idempotency token value * Fixes incorrect default timestamp serialization format * Fixes issues with label encoding * Updates NullAndEmptyHeaders tests
mtdowling
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reapplication of fixes in the following PRs from master:
#321
#333
#335
#349
Fixes several issues with EC2-Query tests
Fixes several issues with the JSON-RPC-1.1 tests
Fixes several issues with the Query tests
Fixes several issues with the Rest-JSON tests
using a shape of the incorrect format
Fixes several issues with the Rest-XML tests
using a shape of the incorrect format
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.