Fix member timestamp format node validation#1948
Merged
Conversation
srchase
approved these changes
Aug 24, 2023
The NodeValidationVisitor vists shapes, members, and then the targets of members. When visiting the target of a member, the context of the referring member was lost, which meant a member with a timestampFormat trait like http-date isn't something the target shape has access to, which will cause validation to fail. We now pass in the referring member as part of the validation context. Closes #1946
mtdowling
force-pushed
the
fix-timestamp-format-traits
branch
from
1071e8e to
9aa3e73
Compare
srchase
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NodeValidationVisitor vists shapes, members, and then the targets of members. When visiting the target of a member, the context of the referring member was lost, which meant a member with a timestampFormat trait like http-date isn't something the target shape has access to, which will cause validation to fail. We now pass in the referring member as part of the validation context.
Closes #1946
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.