Update getAuthSchemes javadoc#1930
Merged
milesziemer merged 1 commit intosmithy-lang:mainfrom Aug 18, 2023
Merged
Conversation
AndrewFossAWS
approved these changes
Aug 16, 2023
syall
reviewed
Aug 16, 2023
smithy-model/src/main/java/software/amazon/smithy/model/knowledge/ServiceIndex.java
Outdated
Show resolved
Hide resolved
Updates javadoc for ServiceIndex::getAuthSchemes to say the returned order is alphabetical. Tests were updated in smithy-lang#1915 to assert this ordering for ServiceIndex::getEffectiveAuthSchemes, but it also made the same update for the ServiceIndex::getAuthSchemes test. The PR didn't include a javadoc update, so the purpose of this PR is to fix that.
milesziemer
force-pushed
the
serviceindex-javadoc-update
branch
from
2a5f47b to
92d1399
Compare
gosar
approved these changes
Aug 16, 2023
syall
approved these changes
Aug 16, 2023
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Updates javadoc for ServiceIndex::getAuthSchemes to say the returned order is alphabetical. Tests were updated in smithy-lang#1915 to assert this ordering for ServiceIndex::getEffectiveAuthSchemes, but it also made the same update for the ServiceIndex::getAuthSchemes test. The PR didn't include a javadoc update, so the purpose of this PR is to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates javadoc for ServiceIndex::getAuthSchemes to say the returned order is alphabetical. Tests were updated in #1915to assert this ordering for ServiceIndex::getEffectiveAuthSchemes, but it also made the same update for the ServiceIndex::getAuthSchemes test. The PR didn't include a javadoc update, so the purpose of this PR is to fix that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.