Allow disabling format on integers#1904
Merged
srchase merged 1 commit intosmithy-lang:mainfrom Aug 2, 2023
Merged
Conversation
mtdowling
approved these changes
Aug 2, 2023
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1899
This PR adds a configuration option,
disableIntegerFormat, which removes theformatproperty which is set when integer types are enabled withuseIntegerType.API Gateway does not support
int32orint64formats on numbers as noted in API Gateway Known Issues:These formats are disabled by default for API Gateway conversions, but are otherwise enabled when using the
useIntegerTypeconfiguration.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.