Cache template directory in init command#1896
Merged
hpmellema merged 34 commits intosmithy-lang:mainfrom Aug 4, 2023
Merged
Conversation
smithy-cli/src/main/java/software/amazon/smithy/cli/commands/InitCommand.java
Show resolved
Hide resolved
Member
|
rather than cache to the temp directory, I suggest caching to the build directory somewhere, allowing |
mtdowling
requested changes
Aug 3, 2023
Member
mtdowling
left a comment
mtdowling
left a comment
There was a problem hiding this comment.
Is it possible to add integration tests for the added functionality of the init command?
mtdowling
approved these changes
Aug 3, 2023
Contributor
Author
|
Update: Issue appears to actually be that git for windows marks pack files as readonly. |
This reverts commit 8e56d37.
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
Adds caching of smithy init template directory in the default system temp directory. This greatly speeds up subsequent executions of both the list and create template subcommands of the smithy init.
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Adds caching of smithy init template directory in the default system temp directory. This greatly speeds up subsequent executions of both the list and create template subcommands of the smithy init.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Caches a copy of the smithy init template directory in the default system temp directory. This greatly speeds up subsequent executions of both the list and create template subcommands of the
smithy init.Previously, creating a template could take up to 6 seconds. With this change that time is down to ~0.3sec after the initial caching of the template repo.
Example Executions
Create a Template
List Templates
Note: the gif recorder used here adds additional lag so these do not accurately represent the time these commands take to execute.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.