Fix validation-model and aws-protocol-tests builds#1880
Merged
jvschneid merged 2 commits intosmithy-lang:mainfrom Jul 24, 2023
Merged
Fix validation-model and aws-protocol-tests builds#1880jvschneid merged 2 commits intosmithy-lang:mainfrom
jvschneid merged 2 commits intosmithy-lang:mainfrom
Conversation
added 2 commits
July 24, 2023 17:21
This commit updates the build task for a pair of packages that depend on the SmithyBuildJar task. This change is needed after changes in common sourcesJar task to include resource files in source jars, which was conflicting with the output of the SmithyBuildJar task output.
jvschneid
changed the title
hpmellema
approved these changes
Jul 24, 2023
jvschneid
pushed a commit
that referenced
this pull request
Jul 24, 2023
This commit updates the build task for a pair of packages that depend on the SmithyBuildJar task. This change is needed after changes in common sourcesJar task to include resource files in source jars, which was conflicting with the output of the SmithyBuildJar task output.
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
This commit updates the build task for a pair of packages that depend on the SmithyBuildJar task. This change is needed after changes in common sourcesJar task to include resource files in source jars, which was conflicting with the output of the SmithyBuildJar task output.
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
This commit updates the build task for a pair of packages that depend on the SmithyBuildJar task. This change is needed after changes in common sourcesJar task to include resource files in source jars, which was conflicting with the output of the SmithyBuildJar task output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit updates the build task for a pair of packages that depend on the SmithyBuildJar task. This change is needed after changes in common sourcesJar task to include resource files in source jars, which was conflicting with the output of the SmithyBuildJar task output, added in #1877.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.