Reduce IDL ambiguity by replacing *WS with [WS]#1699
Merged
mtdowling merged 1 commit intosmithy-lang:mainfrom Mar 31, 2023
Merged
Reduce IDL ambiguity by replacing *WS with [WS]#1699mtdowling merged 1 commit intosmithy-lang:mainfrom
*WS with [WS]#1699mtdowling merged 1 commit intosmithy-lang:mainfrom
Conversation
JordonPhillips
approved these changes
Mar 31, 2023
Contributor
JordonPhillips
left a comment
JordonPhillips
left a comment
There was a problem hiding this comment.
Note for other readers: the ws production already defines it as one or more.
mtdowling
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1249
A grammar containing
defines multiple parse trees.
We can eliminate the ambiguity by replacing
*WSwith[WS].