Correct precedence in NullableIndex and fix diffs#1460
Merged
Conversation
sugmanue
approved these changes
Oct 21, 2022
smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/ChangedDefault.java
Outdated
Show resolved
Hide resolved
Smithy-Diff was flagging acceptable changes of removing `@default(null)` from member when the trait had no effect because the target shape was already nullable. NullableIndex was also giving the `@default(null)` trait precedence over the `@required` trait which is incorrect. Required members are non-nullable, and the `@default(null)` trait doesn't override this. It simply means that there is no default value for the member (so coupled with the required trait, the member is still always present).
mtdowling
force-pushed
the
fix-smithy-diff-default-null-removal
branch
from
7404671 to
8fd5eeb
Compare
sugmanue
approved these changes
Oct 21, 2022
syall
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smithy-Diff was flagging acceptable changes of removing
@default(null)from member when the trait had no effect because the target shape was already nullable. NullableIndex was also giving the@default(null)trait precedence over the@requiredtrait which is incorrect. Required members are non-nullable, and the@default(null)trait doesn't override this. It simply means that there is no default value for the member (so coupled with the required trait, the member is still always present).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.