remove aws query compatible protocol test#1424
Merged
AndrewFossAWS merged 1 commit intomainfrom Sep 24, 2022
Merged
Conversation
b7415d2 to
7b41468
Compare
mtdowling
approved these changes
Sep 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Essentialy the protocol test is not able to verify fields not defined in the error structure. For example,
The httpResponseTests doc states params can only be compatible with the targeted error structure.
The actual error response looks something like this:
The protocol test can only verify
Messagebut not other fields likeCode.Note: AwsQueryCompatibleTrait will add
Codeto the error response.This commit remove the redundant aws query compatible protocol test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.