feat(core/serde): add NumericValue container #1544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not currently in use, but will facilitate future work on serde. It will also unify behavior related to too-large numerics. Currently there is inconsistent behavior among protocols when handling large numbers. Some make best-effort attempts to fit into Number and some throw errors disallowing large numbers. Both of those are not desirable for customers.
We should aim to preserve numeric precision in all cases without coupling to any specific numeric library. A simple string container with a type differentiator field accomplishes that.