fix(server): auto-attach of ValidationException#4588
Merged
Conversation
jasgin
force-pushed
the
fix-validation-exception-auto-attach
branch
2 times, most recently
from
d82ecee to
1adbb19
Compare
…perations Fix two bugs in AttachValidationExceptionToConstrainedOperationInputs that prevented smithy.framework#ValidationException from being automatically attached to constrained operations in certain models. 1. Adds ensureValidationExceptionShapeExists() to add the shape if missing, in case a transforms like removeUnusedShapes is used. 2. Added checking for resource operations. The transformer previously used service.operations (direct operations only), missing operations on resources that also have constrained inputs.
jasgin
force-pushed
the
fix-validation-exception-auto-attach
branch
from
1adbb19 to
811e49e
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two bugs in AttachValidationExceptionToConstrainedOperationInputs that prevented smithy.framework#ValidationException from being automatically attached to constrained operations in certain models.
Adds ensureValidationExceptionShapeExists() to add the shape if missing, in case a transforms like removeUnusedShapes is used.
Added checking for resource operations. The transformer previously used service.operations (direct operations only), missing operations on resources that also have constrained inputs.
Motivation and Context
Description
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.