feat: Add source tag verification to github attest based verifier #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
addsourcetag-gh
branch
2 times, most recently
from
4555ea3 to
6a92806
Compare
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
addsourcetag-gh
branch
from
6a92806 to
df412e0
Compare
| name: "module.bazel using publishing builder and partial source versioned tag", | ||
| artifact: "MODULE-on-tag.bazel", | ||
| source: "github.com/aspect-build/rules_lint", | ||
| sourceVersionTag: pString("v1.3"), |
Member
There was a problem hiding this comment.
I realize there aren't any tests that check for tags that are pre-releases. But can you add a couple, so we can be sure about the behavior.
Contributor
Author
There was a problem hiding this comment.
hrmm.. okay lemme try to generate one
Contributor
Author
There was a problem hiding this comment.
are we checking the behavior of sourceVersionTag? I've added a v9.9.9-rc1, but this doesn't seem the best place to actually test that?
Member
There was a problem hiding this comment.
both, like if the user expects v9.9.9-rc1, and the actual tag is v9.9.9-rc1, then pass
but if if the user expects v.9.9.9, but the actual tag is v9.9.9-rc1, the fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.