Allow the caller to control whether read_env will recurse.#9
Merged
sloria merged 1 commit intosloria:masterfrom Jan 25, 2018
Merged
Allow the caller to control whether read_env will recurse.#9sloria merged 1 commit intosloria:masterfrom
sloria merged 1 commit intosloria:masterfrom
Conversation
The underlying library already exposes a flag to control this behavior, so I'm merely adding a passthrough for that flag.
Owner
|
Makes sense to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying library already exposes a flag to control this behavior,
so I'm merely adding a passthrough for that flag.
I think this flag should be exposed for the same reason it's exposed in the underlying library: it's very useful. For instance, I don't want a web service process potentially recursing up the file system out of its little "jail" (or at least trying to); it's preferable to me that it just throw an
Exception. Since that's already something provided by the underlying library, it seems like a good idea to expose it here. I made the defaultTrueso the change should be backward compatible.