EnvError should inherit from ValueError#50
Merged
sloria merged 1 commit intosloria:masterfrom Dec 10, 2018
syenchuk:patch-1
Merged
EnvError should inherit from ValueError#50sloria merged 1 commit intosloria:masterfrom syenchuk:patch-1
sloria merged 1 commit intosloria:masterfrom
syenchuk:patch-1
Conversation
Owner
|
Makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I feel like EnvError should inherit from ValueError instead of the generic Exception.
For instance,
env.intof "foo" will raiseEnvError, whileint("foo")raisesValueError.It seems to me that both
EnvErrorandValueErrorrefer to an error inside the value that cannot be safely typecasted. SinceValueErroris just a generalization ofEnvError,EnvErrorshould inherit from it.