Add support for custom functions on subcast.#241
Merged
sloria merged 4 commits intosloria:masterfrom Jan 30, 2022
bvanelli:216-fix-subcasts
Merged
Add support for custom functions on subcast.#241sloria merged 4 commits intosloria:masterfrom bvanelli:216-fix-subcasts
sloria merged 4 commits intosloria:masterfrom
bvanelli:216-fix-subcasts
Conversation
- Allows users to define custom functions or extend mashmallow fields.Field class to write custom subcasts for lists, dict keys and dict values. - Gives an alternative to solve #216
sloria
approved these changes
Jan 30, 2022
Owner
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
Apologies for the long delay on reviewing this. This looks great! Thanks a lot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to define custom functions or extend mashmallow fields.Field class to write custom subcasts for lists, dict keys and
dict values. Before, the user was limited to the casts defined on
ma.Schema.TYPE_MAPPINGGives an alternative to solve #216, as shown on the tests.
I also made it available with callables not derived from
mashmallow.fields.Fieldbecause the handy lambda functions could be used too.