Loosen ParserMethod typing#188
Merged
sloria merged 4 commits intosloria:masterfrom Nov 7, 2020
hukkin:patch-2
Merged
Conversation
Owner
|
Thanks! I figured out a way to run mypy in pre-commit while still using dependencies' type annotations: #190 , so I merged that into this. Will release this fix soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loosen ParserMethod typing to help with #186 (comment)
Otherwise users would have to always do an assert:
to fix mypy errors.
Also made mypy run against the
examples/folder to catch typing issues like this early. It is unclear to me whymypy .does not discover theexamples/dir...