Add enum parser#185
Merged
sloria merged 7 commits intosloria:masterfrom Nov 7, 2020
Merged
Conversation
sloria
reviewed
Nov 2, 2020
Owner
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
Thanks! This looks good. Just some nitpicking to address.
Contributor
Author
|
Applied the |
sloria
reviewed
Nov 2, 2020
tomgrin10
force-pushed
the
enum-parser
branch
from
b709959 to
7950065
Compare
Contributor
Author
|
Updated the readme, and left a comment on the |
sloria
approved these changes
Nov 2, 2020
Owner
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
Looks good! I'll merge and release this soon when I'm off the clock
| @env.parser_for("enum") | ||
| def enum_parser(value, choices): | ||
| @env.parser_for("choice") | ||
| def choice_parser(value, choices): |
Owner
There was a problem hiding this comment.
thought (non-blocking): We might want to come up with a different example here since users would use env.enum for this use case rather than a custom parser.
Contributor
Author
There was a problem hiding this comment.
I think the example isn't that bad for now, this deserves a separate issue anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enum parser receives the enum type and parses the enum by its name.