Remove stream kwarg of read_env()#114
Merged
sloria merged 1 commit intosloria:masterfrom Dec 3, 2019
hukkin:rm-stream-kwarg
Merged
Remove stream kwarg of read_env()#114sloria merged 1 commit intosloria:masterfrom hukkin:rm-stream-kwarg
sloria merged 1 commit intosloria:masterfrom
hukkin:rm-stream-kwarg
Conversation
Owner
|
Good catch! As for running mypy on dependencies, feel free to send a PR for that; I won't have time to look into it in the short term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
streamkwarg ofread_env().Firstly, the kwarg is incorrectly type annotated. It is annotated as
strand is passed as a kwarg todotenv.load_dotenv(). That kwarg ofdotenv.load_dotenv(), however, takes anio.StringIO, not a string.Secondly, I believe the
streamkwarg never does anything here.dotenv.load_dotenv()only uses thestreamkwarg if its first kwarg (dotenv_path) is falsy. It seems to me that we always pass a truthy value to that, sostreamis never used. Therefore I suggest we remove it.I recommend running mypy with access to site-packages and their typehints in CI (mypy in pre-commit runs in a venv with no site-packages, unless dependencies listed in .pre-commit-config.yaml). It would catch this and a few other issues.