Fix scatter redraw on both #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset needs_new_x/y in update_buffer rather than redrawCurve Otherwise REDRAW_ON_BOTH will not function properly if redraw frequency is lower than data frequency. In that case it will behave (mostly) like REDRAW_ON_EITHER.
Keep the code explicit to avoid confusion.
jbellister-slac
approved these changes
Oct 8, 2025
Collaborator
jbellister-slac
left a comment
jbellister-slac
left a comment
There was a problem hiding this comment.
Looks good, works as expected now, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redraw on new x and y does not work as expected for new data arriving at rates higher than the redraw rate as
needs_new_xandneeds_new_yare reset only once the redraw actually happens (which may be well after the next data point arrives).Fix by resetting
needs_new_xandneeds_new_ydirectly inupdate_buffer. Allows to receive all points, adding to the buffer according to the set mode (x only, y only, either, both).Test cases have been adjusted to reflect the expected behaviour.