v22.0.4 backport batch 2: backup & security hardening#830
Merged
Conversation
…etry (vitessio#19336) (vitessio#19343) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…ST` opt-in (vitessio#19460) (vitessio#19473) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Mohamed Hamza <mhamza@fastmail.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…ll path building (vitessio#19479) (vitessio#19480) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…..)` to build path (vitessio#19484) (vitessio#19490) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
… flag inputs (vitessio#19486) (vitessio#19500) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## slack-22_0_4-wip #830 +/- ##
===================================================
Coverage ? 69.81%
===================================================
Files ? 1606
Lines ? 214177
Branches ? 0
===================================================
Hits ? 149534
Misses ? 64643
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tanjinx
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this?
Batch 2 of 4 for the v22.0.4 upstream backport. Backup correctness fix + security hardening across all backup engines.
Commits (in order)
Notes
mysqlshellbackupengine: usefileutil.SafePathJoin(...)to build path vitessio/vitess#19484 was applied beforevttablet: hardenExecuteHookRPC and backup engine flag inputs vitessio/vitess#19486 to avoid a conflict inmysqlshellbackupengine.gobackupengine: disallow path traversals via backupMANIFESTon restore vitessio/vitess#19470 (already in our fork)go build ./go/...passes cleanFull upgrade plan
https://gist.github.com/sbaker617/4abb0e0c1856cce1b297b64e6353ec3d
Cherry-picked by Claude Code