Skip to content

v22.0.4 backport batch 2: backup & security hardening#830

Merged
sbaker617 merged 5 commits into
slack-22_0_4-wipfrom
slack-22_0_4-batch-02
Apr 3, 2026
Merged

v22.0.4 backport batch 2: backup & security hardening#830
sbaker617 merged 5 commits into
slack-22_0_4-wipfrom
slack-22_0_4-batch-02

Conversation

@sbaker617
Copy link
Copy Markdown

What's this?

Batch 2 of 4 for the v22.0.4 upstream backport. Backup correctness fix + security hardening across all backup engines.

Commits (in order)

PR Score Description
vitessio#19336 8 fix(backup): propagate file hashes to manifest after retry
vitessio#19460 9 Restore: make loading compressor commands from MANIFEST opt-in
vitessio#19479 9 filebackupstorage: use SafePathJoin for all path building
vitessio#19484 7 mysqlshellbackupengine: use SafePathJoin to build path
vitessio#19486 9 vttablet: harden ExecuteHook RPC and backup engine flag inputs

Notes

Full upgrade plan

https://gist.github.com/sbaker617/4abb0e0c1856cce1b297b64e6353ec3d


Cherry-picked by Claude Code

sbaker617 and others added 5 commits April 2, 2026 18:33
…etry (vitessio#19336) (vitessio#19343)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…ST` opt-in (vitessio#19460) (vitessio#19473)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…ll path building (vitessio#19479) (vitessio#19480)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Steve Baker <s.baker@slack-corp.com>
…..)` to build path (vitessio#19484) (vitessio#19490)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Steve Baker <s.baker@slack-corp.com>
… flag inputs (vitessio#19486) (vitessio#19500)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Steve Baker <s.baker@slack-corp.com>
@github-actions github-actions Bot added this to the v22.0.3 milestone Apr 2, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.63291% with 39 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (slack-22_0_4-wip@5e7acd3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
go/vt/mysqlctl/mysqlshellbackupengine.go 41.02% 23 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go 0.00% 13 Missing ⚠️
go/vt/mysqlctl/filebackupstorage/file.go 66.66% 2 Missing ⚠️
go/vt/hook/hook.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             slack-22_0_4-wip     #830   +/-   ##
===================================================
  Coverage                    ?   69.81%           
===================================================
  Files                       ?     1606           
  Lines                       ?   214177           
  Branches                    ?        0           
===================================================
  Hits                        ?   149534           
  Misses                      ?    64643           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sbaker617 sbaker617 marked this pull request as ready for review April 2, 2026 23:40
@sbaker617 sbaker617 requested a review from a team as a code owner April 2, 2026 23:40
@sbaker617 sbaker617 requested a review from tanjinx April 3, 2026 00:00
@sbaker617 sbaker617 merged commit 9b62099 into slack-22_0_4-wip Apr 3, 2026
92 of 96 checks passed
@sbaker617 sbaker617 deleted the slack-22_0_4-batch-02 branch April 3, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants