Adding ability to overwrite the default processFn method with a custom one. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 93.85% 94.06% +0.20%
==========================================
Files 2 2
Lines 114 118 +4
Branches 22 22
==========================================
+ Hits 107 111 +4
Misses 6 6
Partials 1 1
Continue to review full report at Codecov.
|
4 tasks
bcanseco
previously approved these changes
Apr 8, 2020
|
Awesome! Thanks! |
plugin.js
Outdated
| @@ -18,6 +18,31 @@ try { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * The default function for adding the CSP to the head of a document | |||
| * Can be overwritten to allow the developer can process the CSP in their own way | |||
|
Nice! Give the people what they want! One little nit, but otherwise looks good. +1 |
added 2 commits
April 9, 2020 09:30
New option in additionalOpts to allow the developer to use the built CSP in any way they want to. `processFn` can either be defined on the CspHtmlWebpackPlugin, or in individual HtmlWebpackPlugin instances
…the full configuration is not needed to enable this plugin
AnujRNair
force-pushed
the
an-custom-process-function
branch
from
bcc7022 to
b56efa7
Compare
|
I've now merged this and bumped the npm package version - thanks for the reviews! |
bcanseco
added a commit
to bcanseco/borja.io
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows a developer to define a custom
processFnmethod to overwrite the default behaviour of inlining the policy into the head of the document we're currently processing.Covers a request from #44, and an issue raised in #57
Implementation Details
defaultProcessFnfunction, and made it the default behaviour so as to be backwards compatible.CspHtmlWebpackPluginadditionalOptsobject, or from theHtmlWebpackPlugininstancecspPluginobject. This can allow for different processing functions perHtmlWebpackPlugininstance