This repository was archived by the owner on Oct 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Better alternative technique for dragging the keyboard on iOS 9/10 #495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d up on iOS 9, without using any private APIs
…th the mockup. Reproducible by scrolling up very quickly, while the keyboard is visible. This is a temporary fix, since it comes with a side effect too.
… keyboard snapshot/swap whenever the finger touches the input bar (much more reliable)
…and tweaks the internals to work in other edge cases.
…This helps avoiding a lag when dragging the text input bar while the keyboard placeholder isn't yet shown. Still needs tweaks.
…mproves the keyboard window hiding so it doesn't glitch too often.
… minor refactoring/renaming
We've decided against merging this in for now |
I've created a branch with interactive keyboard panning support based on what u've proposed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #355, this PR includes a more reliable solution for the keyboard panning feature:
UITabBar
, view controller containment or modal presentations.SLKTextViewController
.Downsides:
UIApplication
's windows hierarchy change in future iOS releases. We will be monitoring this and try our best to patch.Closes #355