Skip to content
This repository was archived by the owner on Nov 3, 2025. It is now read-only.

[PanModal] Track all dismiss events through callbacks#91

Merged
ste57 merged 1 commit intomasterfrom
panModal/callback-all-dismiss-events
Mar 25, 2020
Merged

[PanModal] Track all dismiss events through callbacks#91
ste57 merged 1 commit intomasterfrom
panModal/callback-all-dismiss-events

Conversation

@ste57
Copy link
Contributor

@ste57 ste57 commented Mar 25, 2020

Summary

  • Whenever the presentingViewController is dismissed, in any way, call panModalWillDismiss() & PanModalDidDismiss()

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Stephen Sowole seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ste57 ste57 requested a review from TosinAF March 25, 2020 00:40
@ste57 ste57 changed the title [PanModal] Track all dismiss events through callbacks [Pan Modal] Track all dismiss events through callbacks Mar 25, 2020
@ste57 ste57 changed the title [Pan Modal] Track all dismiss events through callbacks [PanModal] Track all dismiss events through callbacks Mar 25, 2020
@ste57 ste57 merged commit 22b4ddd into master Mar 25, 2020
@ste57 ste57 deleted the panModal/callback-all-dismiss-events branch March 25, 2020 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants