Skip to content

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Sep 17, 2024

This pull request resolves #1373 and marks the useless properties as deprecated for the future.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Sep 17, 2024
@seratch seratch added this to the 1.43.1 milestone Sep 17, 2024
@seratch seratch self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (46b1fcd) to head (bb42ba3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1374      +/-   ##
============================================
- Coverage     74.42%   74.39%   -0.03%     
+ Complexity     4277     4276       -1     
============================================
  Files           461      461              
  Lines         13347    13347              
  Branches       1370     1370              
============================================
- Hits           9933     9930       -3     
- Misses         2614     2617       +3     
  Partials        800      800              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 8b5b30e into slackapi:main Sep 17, 2024
6 checks passed
@seratch seratch deleted the issue-1373 branch September 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogsResponse in AuditClient returns "ok: false" when request was a success
1 participant