This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Make sure builder always validates function files#18
Merged
Conversation
selfcontained
approved these changes
Apr 28, 2022
selfcontained
left a comment
selfcontained
left a comment
There was a problem hiding this comment.
Works great, thanks! I tested this out against a number of different project structures, with and without functions, with and without the SDK, layered manifest files, and it catches invalid source_file values as expected. Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make sure we are always validating function files exist at the location regardless of if they are outputting the manifest or not
Details
When doing a local run we were not seeing an error until the function was triggered because during a local run the CLI passes the flag for
manifestOnly.