Return a StatusCodeError when a workspace's message limit is exceeded #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlopes
approved these changes
Mar 10, 2025
Collaborator
nlopes
left a comment
nlopes
left a comment
There was a problem hiding this comment.
Thanks @greysteil! This should go out with 0.17 which hopefully I'll release soon.
Collaborator
|
@greysteil I think you'll need to change the testing endpoint as |
greysteil
force-pushed
the
handle-message-limit-exceeded
branch
from
ae402a1 to
e356192
Compare
Contributor
Author
|
@nlopes - updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this library throws a
strconv.NumErrorwhen attempting to post messages to a Slack workspace that has exceeded its message limit. It does so because Slack returns a 429 without aRetry-Afterheader for those requests.This PR improves the situation by instead returning a
StatusCodeError. I couldn't see any obvious way to provide a more detailed error without creating a new error class. To only additional information returned from Slack for these errors is a body that readsmessage_limit_exceeded.