Skip to content

Commit 5bad841

Browse files
authored
Subteam events in socketmode should have their 'Count' entries as numbers, not strings (#1417)
2 parents 2cdeceb + d236bd9 commit 5bad841

File tree

5 files changed

+7
-9
lines changed

5 files changed

+7
-9
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
*~
33
.idea/
44
/vendor/
5-
.env
5+
.env*

examples/socketmode/socketmode.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ import (
66
"os"
77
"strings"
88

9-
"github.com/slack-go/slack/socketmode"
10-
119
"github.com/slack-go/slack"
1210
"github.com/slack-go/slack/slackevents"
11+
"github.com/slack-go/slack/socketmode"
1312
)
1413

1514
func main() {

examples/socketmode_handler/socketmode_handler.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ import (
66
"os"
77
"strings"
88

9+
"github.com/slack-go/slack"
910
"github.com/slack-go/slack/slackevents"
1011
"github.com/slack-go/slack/socketmode"
11-
12-
"github.com/slack-go/slack"
1312
)
1413

1514
func main() {

slackevents/inner_events.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -814,9 +814,9 @@ type SubteamMembersChangedEvent struct {
814814
DatePreviousUpdate int `json:"date_previous_update"`
815815
DateUpdate int64 `json:"date_update"`
816816
AddedUsers []string `json:"added_users"`
817-
AddedUsersCount string `json:"added_users_count"`
817+
AddedUsersCount int `json:"added_users_count"`
818818
RemovedUsers []string `json:"removed_users"`
819-
RemovedUsersCount string `json:"removed_users_count"`
819+
RemovedUsersCount int `json:"removed_users_count"`
820820
}
821821

822822
type SubteamSelfAddedEvent struct {

slackevents/inner_events_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1968,9 +1968,9 @@ func TestSubteamMembersChangedEvent(t *testing.T) {
19681968
"date_previous_update": 1446670362,
19691969
"date_update": 1624473600,
19701970
"added_users": ["U1234567890"],
1971-
"added_users_count": "3",
1971+
"added_users_count": 3,
19721972
"removed_users": ["U0987654321"],
1973-
"removed_users_count": "1"
1973+
"removed_users_count": 1
19741974
}
19751975
`)
19761976

0 commit comments

Comments
 (0)