Skip to content

Commit d236bd9

Browse files
committed
[fix]: 'Count' entries in Subteam events should be int not string
The slack documentation gets it wrong: their example shows strings but looking at their [own implementation of the types in their node sdk](https://github.com/slackapi/node-slack-sdk/blob/31c60f863c36cd74837fc9ad5d5111532451ffcd/packages/types/src/events/subteam.ts#L44 it certainly seems it should be int.
1 parent a273556 commit d236bd9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

slackevents/inner_events.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -814,9 +814,9 @@ type SubteamMembersChangedEvent struct {
814814
DatePreviousUpdate int `json:"date_previous_update"`
815815
DateUpdate int64 `json:"date_update"`
816816
AddedUsers []string `json:"added_users"`
817-
AddedUsersCount string `json:"added_users_count"`
817+
AddedUsersCount int `json:"added_users_count"`
818818
RemovedUsers []string `json:"removed_users"`
819-
RemovedUsersCount string `json:"removed_users_count"`
819+
RemovedUsersCount int `json:"removed_users_count"`
820820
}
821821

822822
type SubteamSelfAddedEvent struct {

slackevents/inner_events_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1968,9 +1968,9 @@ func TestSubteamMembersChangedEvent(t *testing.T) {
19681968
"date_previous_update": 1446670362,
19691969
"date_update": 1624473600,
19701970
"added_users": ["U1234567890"],
1971-
"added_users_count": "3",
1971+
"added_users_count": 3,
19721972
"removed_users": ["U0987654321"],
1973-
"removed_users_count": "1"
1973+
"removed_users_count": 1
19741974
}
19751975
`)
19761976

0 commit comments

Comments
 (0)