Skip to content

Simple fix to duplicate/overlapping logcat windows.#1761

Merged
skylot merged 3 commits into
skylot:masterfrom
zach-snell:bugfix/logcat_duplicatewindows
Jan 21, 2023
Merged

Simple fix to duplicate/overlapping logcat windows.#1761
skylot merged 3 commits into
skylot:masterfrom
zach-snell:bugfix/logcat_duplicatewindows

Conversation

@zach-snell

Copy link
Copy Markdown
Contributor

Could be improved by not re-creating UI every time

Description

Quick fix for logcat debug window causing duplicate windows and incorrect displayed content.

#1752

@skylot skylot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I will apply removing of trailing spaces.

Comment thread jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated
Comment thread jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated
Comment thread jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java Outdated
@skylot

skylot commented Jan 18, 2023

Copy link
Copy Markdown
Owner

I think this can be used as quick fix until @jmlitfi apply changes mentioned in #1752 (comment)

@skylot skylot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another try to fix trailing spaces using GitHub suggestions 🤣

Comment thread jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java
Comment thread jadx-gui/src/main/java/jadx/gui/ui/panel/LogcatPanel.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants