Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1109
As described in the issue, I've setup pre-commit with black+isort+flake8 configuration. I've also added radon as a seperate checker from pre-commit for cyclomatic complexity and to help maintain readability as well. The current rating is A(2.5044124477473293) which is really good, so no major action needs to be taken for now.
For the pre-commit hooks, the following formatters/linters are setup:
black: It auto-formats code to a strict, consistent style.
flake8: It lints for style, formatting, and some basic code quality issues.
isort: It automatically sorts imports by PEP8 standards and custom rules.
After executing
pre-commit run --all-files
, it modified 70+ files with changes, so I decided to not include the changes in this PR for now.Could you please review?
cc: @BenjaminBossan